Azure / Azure/azure-sdk-tools

Breaking change tooling: same-version preview breaking change results in `BreakingChangeReviewRequired` label instead of `VersioningReviewRequired` label.

Open
#8,429 0 comments 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Breaking Changes bug Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

According to this doc:

- https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-brch-deep#versioningreviewrequired-label

`VersioningReviewRequired` label should be added to same-version breaking changes in `preview` API version.
But here we can see automation adding `BreakingChangeReviewRequired`:

- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3862439&view=logs&j=98f87804-8e1f-5655-af02-e80aefa7aa97&t=65457206-7ab6-5966-2a2f-9ae3efa14a03&l=62
- https://github.com/Azure/azure-rest-api-specs/pull/29319/checks'
- https://github.com/Azure/azure-rest-api-specs/pull/29319#issuecomment-2161675292

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.