Breaking Change Detector is flagging false-positives
- Dominant language
- C#
- Stars
- 135
- Forks
- 260
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 115
Description
This PR removes spaces from the model names: https://github.com/Azure/azure-rest-api-specs/pull/26303
Which is currently flagged as a breaking change to both `Azure/azure-sdk-for-go` and `Azure/azure-sdk-for-js` - however both of these are incorrect.
Whilst the Swagger model is currently named `IPv6 FirewallRule`, this gets transformed to `IPv6FirewallRule` - in both `Azure/azure-sdk-for-go`:
https://github.com/Azure/azure-sdk-for-go/blob/f52645651a7e4a4ae3dacc7bca501319deeab882/sdk/resourcemanager/sql/armsql/models.go#L2655-L2668
.. and `Azure/azure-sdk-for-js`:
https://github.com/Azure/azure-sdk-for-js/blob/bee878fa80bc0d4766f72a53e818a112ad257545/sdk/sql/arm-sql/src/models/index.ts#L8784-L8789
As such this isn't a breaking change)
---
Would someone be able to take a look into this?
As a side-note, as mentioned in https://github.com/Azure/azure-rest-api-specs/pull/26303 I suspect there's a missing linter for catching spaces (and square brackets etc) in Model/Constant names - but I'm not sure where'd be best to raise that issue?
Thanks!
Contributor guide
Assessment
This issue has not been assessed yet.