Azure / Azure/azure-sdk-tools

Swagger BreakingChange - false positive related to x-ms-enum field

Open
#7,749 1 comment 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Breaking Changes Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

This Swagger BreakingChange job failed: https://github.com/Azure/azure-rest-api-specs/pull/27895/checks

The error message is that certain `x-ms-enum` fields are missing the required property "name". The PR is very small and has no impact on any fields related to the ones with the warnings, so I believe this is a false positive.

It appears to be related to a similar problem that this API had with LintDiff, where TypeSpec's generation of static enums was not compatible with LintDiff's expectations. See https://teams.microsoft.com/l/message/19:906c1efbbec54dc8949ac736633e6bdf@thread.skype/1705001720452?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1705001720452&teamName=Azure%20SDK&channelName=TypeSpec%20Discussion&createdTime=1705001720452 for more details.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.