Azure / Azure/azure-sdk-tools

LintDiff (most likely) incorrectly concludes in several cases it should not run its validation

Open
#7,730 0 comments 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

Original post by @rkmanda [on Teams, here](https://teams.microsoft.com/l/message/19:4f661242c446452e895359cc3ef45125@thread.tacv2/1708149851163?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=0cab4ce9-7691-42ae-82e3-460d4346a710&parentMessageId=1708139824699&teamName=ARM%20API%20Reviewers&channelName=ARM%20linter%20rules&createdTime=1708149851163)

We need to evaluate all these cases and double-check if LintDiff correctly decided it doesn't need to run its validation.

Cases discovered so far by @rkmanda :
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3496404&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
- https://github.com/Azure/azure-rest-api-specs-pr/pull/16821
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3493551&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
- https://github.com/Azure/azure-rest-api-specs/pull/27581
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3471570&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
- https://github.com/Azure/azure-rest-api-specs/pull/27666
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3474334&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
- https://github.com/Azure/azure-rest-api-specs-pr/pull/16972
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3498415&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
- https://github.com/Azure/azure-rest-api-specs/pull/27682
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3479301&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
- https://github.com/Azure/azure-rest-api-specs/pull/27696
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3484822&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7
- https://github.com/Azure/azure-rest-api-specs/pull/27709
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3504558&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7&l=64
- https://github.com/Azure/azure-rest-api-specs-pr/pull/16835

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.