Azure / Azure/azure-sdk-tools

Revoke the previous approved breaking changes if ARM request changes after the previous approval

Open
#7,709 3 comments 1 reaction 1 assignee Claimed by @konrad-jamrozik View on GitHub
Breaking Changes Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

As title, sometimes, service team get ARM signed off from a long time ago and SDK breaking changes review happens soon after that, but cases are common that service team could still need to change something after all the signed offs and ARM will revoke the ARM sign off labels, at that time, we should revoke all the approved SDK breaking changes as well.

See https://github.com/Azure/azure-rest-api-specs/pull/24625 for an example. the previous invalid SDK breaking change approve labels cause we fail to run CI check properly, and the PR even get merged with all the SDK generation failed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.