Azure / Azure/azure-sdk-tools

[APIView] Epic: Management Plane Namespace Reviews

Open
#7,607 2 comments 0 reactions 0 assignees View on GitHub
APIView Engagement Experience Epic
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

New Requirements after Arch. board feedback:

View this [Powerpoint](https://microsoft-my.sharepoint.com/:p:/p/jamesferry/EU4Fqum6tY1KoNh6xwPe1MMBBw2DGuumW0LcAWDYOQm3Zg?e=GFUpia) for what the flow looks like

- A "Pending First Release" and "Recently-Approved First Release" approvals section should be created in the pending reviews tab (this is only present in the admin version), this would have a list of all pending reviews with their name, author, last updated, type, requested on, request by fields (these are present for the other pending review types).

![Image](https://github.com/user-attachments/assets/55ba25f6-123a-4b69-b4e0-909b72fa72d8)

- Architects should have the ability to sign up for email notifications when a namespace review is ready for review. (I believe these email notifications exist already, if not I'm happy to draft one)
- Service teams creating API views for namespace approvals should also receive notifications when there are comments or their review is approved.
- Auto close and approve the namespace reviews if there are no open comments after 3 days. Architects will need to close any unresolved comments to get the namespace approved. We can restart the 3-day timer after a comment closes.
- Each approver will use the "Approve first release" button which already exists in API view, we will need a red button below this one which says: "Reject first release". This button will prompt the architect to give feedback on why they are rejecting the namespace and comment on the line of code (in the TypeSpec file) with the namespace they are rejecting.

![Image](https://github.com/user-attachments/assets/669fa821-6874-46fc-8c6d-d994fbc8e069)

Contributor guide

Open the contributing guide

Research direction

Start with the linked PowerPoint and the APIView pending reviews tab, then trace the existing "Approve first release" flow. Done means supporting the two approval sections, architect and service-team notifications, the three-day auto-close and approval behavior, and rejection feedback with a TypeSpec namespace comment.

Written by the indexing model from the issue text.

Assessment

Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.