[Breaking Change] RemovedClientParameter validation may be incorrect
- Dominant language
- C#
- Stars
- 135
- Forks
- 260
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 115
Description
In https://github.com/Azure/azure-rest-api-specs-pr/pull/16124/checks?check_run_id=19232503164, the validation said I removed the `$.parameters["WeatherForecastResource.weatherForecastResourceName"]` parameter, but it actually wasn't:
* Old definition: https://github.com/Azure/azure-rest-api-specs-pr/blob/faecfa762ebb5e572a9f6c820466b50788291b5e/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L555C6-L555C57
* Forecasts_Get: https://github.com/Azure/azure-rest-api-specs-pr/blob/faecfa762ebb5e572a9f6c820466b50788291b5e/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L193
* Forecasts_CreateOrUpdate: https://github.com/Azure/azure-rest-api-specs-pr/blob/faecfa762ebb5e572a9f6c820466b50788291b5e/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L236
* Forecasts_Update: https://github.com/Azure/azure-rest-api-specs-pr/blob/faecfa762ebb5e572a9f6c820466b50788291b5e/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L305
* Forecasts_Delete: https://github.com/Azure/azure-rest-api-specs-pr/blob/faecfa762ebb5e572a9f6c820466b50788291b5e/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L357
* New usages (inlined):
* Forecasts_Get: https://github.com/Azure/azure-rest-api-specs-pr/blob/4be13f543d341224beabeb5e998b7560876141a1/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L193
* Forecasts_CreateOrUpdate: https://github.com/Azure/azure-rest-api-specs-pr/blob/4be13f543d341224beabeb5e998b7560876141a1/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L240
* Forecasts_Update: https://github.com/Azure/azure-rest-api-specs-pr/blob/4be13f543d341224beabeb5e998b7560876141a1/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L313
* Forecasts_Delete: https://github.com/Azure/azure-rest-api-specs-pr/blob/4be13f543d341224beabeb5e998b7560876141a1/specification/secretmanagementtestsvc/resource-manager/Microsoft.SecretManagementSampleProvider/preview/2022-08-01-preview/secretmanagementsample.json#L369
The TypeSpec emitter for swagger did this for reasons unknown, but it resolves to the same thing.
Contributor guide
Assessment
This issue has not been assessed yet.