Azure / Azure/azure-sdk-tools

[LintDiff] Lint Errors don't display correctly, and don't pick the base version from main for which it is comparing to.

Open
#7,326 0 comments 1 reaction 1 assignee Assigned to @konrad-jamrozik View on GitHub
Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

**Describe the bug**
The following PR caught errors from the PR and displayed the new errors on the wrong view i.e. "The following errors/warnings exist before current PR submission" instead of displaying on the view "[must fix]The following errors/warnings are introduced by current PR:"
Here is the PR https://github.com/Azure/azure-rest-api-specs/pull/23878/checks?check_run_id=13345461834

This PR also dint pick the base version from main branch

![image](https://github.com/Azure/azure-openapi-validator/assets/14865963/311b987d-6369-4a02-89fd-da157232c92e)

Found all these findings while investigating this issue https://msazure.visualstudio.com/One/_workitems/edit/24905712

**To Reproduce**
Steps to reproduce the behavior:
Click this link https://github.com/Azure/azure-rest-api-specs/pull/23878/checks?check_run_id=13345461834
And check this pipelien https://dev.azure.com/azure-sdk//internal/_build/results?buildId=2761863&view=logs&j=688669d0-441c-57c3-cf6d-f89a22ccfa5d

The task I was working says "GetCollectionOnlyHasValueAndNextLink" rule on this path "/subscriptions/{subscriptionId}/providers/Microsoft.NetApp/locations/{location}/regionInfo" was no caught. But the exception was caught, but it did get caught in the "before PR section"

![image](https://github.com/Azure/azure-openapi-validator/assets/14865963/4589da14-886b-4c57-8974-144c631abf5f)

**Expected behavior**
Most of the errors should be displayed on the "errors/warnings are introduced by current PR" view but instead it displayed on the "before current PR submission view"
And also it should display the base version of main branch which it was comparing to

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.