Azure / Azure/azure-sdk-tools

OAV: OBJECT_MISSING_REQUIRED_PROPERTY on required secrets properties

Open
#6,633 0 comments 0 reactions 1 assignee Claimed by @scbedd View on GitHub
Central-EngSys customer-reported question
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

Right now oav ModelValidation fails if a Typespec-generated spec has secret properties that are required during Create. The secrets are not returned in the example responses for security reasons, and this triggers the OBJECT_MISSING_REQUIRED_PROPERTY failure. When a required property is marked as secret, this error should not be returned.

An example of this failing in practice: https://github.com/Azure/azure-rest-api-specs-pr/pull/13674/checks?check_run_id=15396409187

MSFT internal teams thread about this: [here](https://teams.microsoft.com/l/message/19:0351f5f9404446e4b4fd4eaf2c27448d@thread.skype/1687796357422?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1687796357422&teamName=Azure%20SDK&channelName=API%20Spec%20Review&createdTime=1687796357422)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.