Azure / Azure/azure-sdk-tools

[JimBot] Extend `LockClosedIssues` to include Pull Requests

Open
#6,500 1 comment 0 reactions 0 assignees View on GitHub
GitHub Event Processor
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
144

Description

Currently the [LockedClosedIssues](https://github.com/Azure/azure-sdk-tools/blob/main/tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/EventProcessing/ScheduledEventProcessing.cs#L491) rule targets only issues. Since implementing this rule, we've started to see activity where comments are being left on old pull requests that have been long since closed. We should consider extending the rule to lock both issues and pull requests.

Contributor guide

Open the contributing guide

Research direction

Start in tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor/EventProcessing/ScheduledEventProcessing.cs around the LockClosedIssues rule at line 491. Trace how the rule identifies closed issues and determine how the same behavior should cover pull requests; it is done when long-closed pull requests are locked as well as issues.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.