Azure / Azure/azure-sdk-tools

[Breaking Change] shows as Failed but Signoff API Spec Readiness shows as not required

Open
#6,327 10 comments 0 reactions 1 assignee Assigned to @konrad-jamrozik View on GitHub
Breaking Changes bug Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

New service working on the initial release of their beta SDKs for management plane. They have not published their initial preview API version. They are working on finalizing the changes to preview API version in the private repo and will publish at public preview launch.

The PR met API readiness for signoff, which looks to be correct as there is no ARM Review required for these changes and the breaking changes would not be relevant for this PR. However, it is confusing b/c the breaking change error and ARM review not available are seen earlier in the flow. The service team engineer pinged me b/c he was confused by these results.

- [ ] **Suggested requirement:** If ARM Review or Breaking Change are not relevant for the PR, then show not required on the earlier screens.

![image](https://github.com/Azure/azure-sdk-tools/assets/67656762/e6460b69-57a8-4a1f-87fd-5e2ab0e12b15)
![image](https://github.com/Azure/azure-sdk-tools/assets/67656762/f8aeee82-8453-4a65-adec-27db39328388)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.