Azure / Azure/azure-sdk-tools

Chris Eggert: WaitForARMFeedback is being applied to PRs in RPSaaSDev branch.

Open
#6,056 0 comments 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
bug Central-EngSys Spec PR Tools Support
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

See [this Teams thread](https://teams.microsoft.com/l/message/19:78cd6c72c41240dc84a36523af60b88a@thread.tacv2/1682534313011?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=0cab4ce9-7691-42ae-82e3-460d4346a710&parentMessageId=1682534313011&teamName=ARM%20API%20Reviewers&channelName=ARM%20swagger%20reviews&createdTime=1682534313011&allowXTenantAccess=false)

> Chris Eggert:
>
> WaitForARMFeedback is being applied to PRs in RPSaaSDev branch. I was under the impression that branch was for dogfood related work and is not a place where reviews happen. https://eng.ms/docs/products/arm/rpaas/swaggeronboarding#supported-github-reposbranches
>
> Roopesh Manda is my understanding correct? If so, who can I bug about getting the label automation changed to not add the tag there?

> (...)

> Roopesh Manda:
>
> Wes Haggard, Konrad Jamrozik We were expecting the bot to not add the WaitForARMFeedback label automatically to the PRs opened in RPSaaSDev branch and this has been the case for a while now. However this didnt seem to be the case for the PR Chris linked here. Could you folks pl take a look at whats expected with the bot and if there were any recent changes made?

> Mark Cowlishaw:
>
> Yes, should not be added for RPSaaSDev

> Wes Haggard:
>
> I'm trying to track down why it was added but it looks like some of the summary process failed https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2730609&view=logs&j=d6a48a56-e996-55ca-2302-c3a9a7be685b&t=f4162ac4-a5be-580e-39db-db0d6209bd6a which might be part of the issue why it was miss-labeled. Konrad Jamrozik lets add a tracking issue to hunt this down.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.