Azure / Azure/azure-sdk-tools

[Breaking Change][PR Workflow] REST API Breaking Changes PR check should check who added the suppression label

Open
#6,035 9 comments 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Breaking Changes Central-EngSys feature-request Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

PRs in the azure-rest-api-specs repo are blocked from merging if the Breaking Changes PR check reports a failure. But the result of the Breaking Changes check is squashed if the "Approved-BreakingChange" label has been added to the PR. That label is supposed to signify that the PR was reviewed by the Breaking Change review board and determined to be an allowable change.

Unfortunately, there is no means to prevent _any_ user with labelling permissions to add the "Approved-BreakingChange" label, so changes that should not be permitted are allowed to merge, resulting in customer disruption.

An example is [PR 23647](https://github.com/Azure/azure-rest-api-specs/pull/23647).

image

image

Since we cannot restrict who can add the label, I think the PR check must only be squashed if the label was added by a member of the breaking change review board or otherwise trained and responsible user.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.