Azure / Azure/azure-sdk-tools

[Avocado] Validate that file paths are not too long

Open
#5,931 1 comment 0 reactions 1 assignee Assigned to @konrad-jamrozik View on GitHub
Central-EngSys Spec PR Tools specs-model
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

(I didn't propose this. This was proposed by tianxchen-ms from the Shanghai team on Nov 30, 2022; I just converted it from draft)

issues: [Spec PR validation broken for PoliCheck and CredScan jobs because of long path issues · Issue #3825 · Azure/azure-sdk-tools (github.com)](https://github.com/Azure/azure-sdk-tools/issues/3825)

Feedback from wes:

we need to be a start enforcing that teams don't introduce paths that are too long. WE cannot depend on folks having longpath configured correctly on windows as that will be a blocker in a lot of cases.

For reference we have https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/pipelines/templates/steps/verify-path-length.yml which we use in each of our SDK repos to enforce this.

Ruoxuan Wang
[commented Oct 19]

From my perspective, I recommend to implement a validation rule in avocado. The reason is use `verify-path-length.yml` need to build another CI check. Since this function is quite small, so it's unnecessary to build addition check to do that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.