Azure / Azure/azure-sdk-tools

[Breaking Change] OAD support request by Tim Lovell-Smith: non-breaking change alerted on (3/14/2023)

Open
#5,730 3 comments 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Breaking Changes bug Central-EngSys Spec PR Tools Support
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

As reported on email thread with subject `New Response to Swagger Validation Feedback: 3/14/2023 3:33:46 PM`

https://github.com/Azure/azure-rest-api-specs/pull/23049/checks?check_run_id=11963838160

> Question detail:
> This refactoring seems like a non-breaking change to swagger to me.
> But it is flagged as a breaking change, because [I think] it is too sensitive to $ref redirection.
> https://github.com/Azure/azure-rest-api-specs/pull/23049
>
> ❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
> New: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1302:9
> Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1302:9
>
> ❌ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
> New: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1927:9
> Old: Microsoft.Cache/preview/2023-03-01-preview/redisenterprise.json#L1940:9

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.