Azure / Azure/azure-sdk-tools

[Breaking Change] Inconsistent labeling for breaking change review

Open
#5,689 1 comment 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Breaking Changes bug Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

The labeling for breaking change review appears to be inconsistent between the internal azure-rest-api-specs-pr repo and the public azure-rest-api-specs repo. [PR 2300](https://github.com/Azure/azure-rest-api-specs/pull/23000) in the public repo was flagged for breaking change review

![image](https://user-images.githubusercontent.com/85643503/224489921-2a6fb438-dea1-46eb-a736-45ff23e44d5f.png)

as it should have been because the Swagger BreakingChange PR check failed -- found 7 errors. But this PR was just applying changes already reviewed and approved in the internal repo in [PR 9489](https://github.com/Azure/azure-rest-api-specs-pr/pull/9489) which targeted the RPSaaSMaster branch.

![image](https://user-images.githubusercontent.com/85643503/224490168-124b9cb3-0e87-4e80-a183-2ed5b33cfd93.png)

The Swagger BreakingChange check in PR 9489 also failed (in this case only 6 errors ... not sure why one is missing but that's not important) but the PR was never labeled BreakingChangeReviewRequired.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.