Azure / Azure/azure-sdk-tools

PR pipeline in azure-rest-api-specs should flag PR with Cadl but not package-lock.json

Open
#5,483 0 comments 0 reactions 0 assignees View on GitHub
TypeSpec
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

We should require the package-lock.json file to be present for any Cadl definition. It can either be included in the PR or already present in the repo (not changed), but it should not be absent. We need package-lock.json to ensure that the REST API can be reliably recreated at any point in the future.

Contributor guide

Open the contributing guide

Research direction

Start by locating the PR pipeline used for azure-rest-api-specs and inspect how Cadl definitions are detected. Verify the check distinguishes an included package-lock.json from one already present in the repository, and confirm that a Cadl definition without either is flagged while one with either is accepted.

Written by the indexing model from the issue text.

Assessment

Domain
ci-cd, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.