Azure / Azure/azure-sdk-tools

[Breaking Change] False Positive: reporting spurious/unsubstantiated 'required' status changed

Open
#5,429 4 comments 1 reaction 1 assignee Assigned to @konrad-jamrozik View on GitHub
Breaking Changes bug Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

The Breaking changes report for [PR 21914](https://github.com/Azure/azure-rest-api-specs/pull/21914) is reporting many 'required' status changed issues that either don't exist or are not clearly substantiated in the report. Take the first one as an example:

![image](https://user-images.githubusercontent.com/85643503/218580620-076e739d-ccbc-4d81-823c-916e827fb130.png)

The ["old" link](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/datamigration/resource-manager/Microsoft.DataMigration/stable/2021-06-30/datamigration.json#L111:9) goes to:

![image](https://user-images.githubusercontent.com/85643503/218580794-363d642e-2a66-4ba0-b3f5-fbf1bec8a0f3.png)

and the ["new" link](https://github.com/Azure/azure-rest-api-specs/blob/f3378cd0785625698cd43a9e7c1da4c498f0b08f/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2022-11-30-preview/datamigration.json#L111:9) goes to

![image](https://user-images.githubusercontent.com/85643503/218581072-b5e724f4-c22f-41a1-8bea-8c4e99c68e6b.png)

The "service" parameter in the "old" version is

![image](https://user-images.githubusercontent.com/85643503/218581611-d0f2eafd-9218-484d-95e1-7a6c3e1a9959.png)

and in the new version

![image](https://user-images.githubusercontent.com/85643503/218581488-a95daaaa-84bf-49ef-a614-801cc9def6ba.png)

which look identical to me.

The ["old" DataMigrationService schema](https://github.com/Azure/azure-rest-api-specs/blob/dev-datamigration-2022-11-30-preview/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2022-03-30-preview/definitions/Services.json#L83)

![image](https://user-images.githubusercontent.com/85643503/218582567-2db12869-bb93-4fa4-82d4-8ed1b5e61a55.png)

and the [new one](https://github.com/Azure/azure-rest-api-specs/blob/dev-datamigration-2022-11-30-preview/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2022-11-30-preview/definitions/Services.json#L83)

![image](https://user-images.githubusercontent.com/85643503/218582840-35891163-071e-46db-9704-3f7b683ed23e.png)

And the next level down too. I cannot find where this issue is, so I think something is broken in the tool. At the very least, if there is some property deep down that has changed its required status, please point directly to it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.