Azure / Azure/azure-sdk-tools

Swagger Model Validation PR check gives false positive errors

Open
#4,519 4 comments 0 reactions 1 assignee Assigned to @scbedd View on GitHub
Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
144

Description

In [PR 9407](https://github.com/Azure/azure-rest-api-specs-pr/pull/9407) the [Swagger Model Validation PR check](https://github.com/Azure/azure-rest-api-specs-pr/pull/9407/checks?check_run_id=9103809911) reports a number of INVALID_TYPE errors like this:

image

The [documentation for INVALID_TYPE](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md#INVALID_TYPE) shows the format of the error message as
> Output Message: Expected type {0} but found type {1}.

Note the expected type `{0}` is not shown in the error messages above. I checked a few of these and in all cases the type was clearly defined as `type: object` (with no properties). So the messages are false positives -- the type is defined to be an object and that is what is specified in the example.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.