Azure / Azure/azure-sdk-tools

[APIView] Block PRs from being merged in GitHub

Open
#4,375 3 comments 1 reaction 0 assignees View on GitHub
APIView feature-request
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

With swagger/Cadl support coming online for APIView, I feel one important feature that's needed is to somehow block PRs on GitHub from being merged while there are unresolved comments. Ideally, showing those comments on appropriate lines in the PR would be nice so we're not forced to use separate tools- GitHub and APIView - but perhaps consider that a stretch or I can open another issue.

At the very least, perhaps some sort of hook to prevent merging while there are unresolved comments. I assume links will still be added to PRs so that service teams know to look at APIView, but randomized assignees for merging need to know why a PR is blocked and not be able to override e.g., a required check.

Contributor guide

Open the contributing guide

Research direction

The issue identifies APIView and GitHub but does not name files, tests, or an entry point. Start by locating APIView's existing pull-request integration and the repository's GitHub checks or merge-control configuration; completion would require an agreed design for blocking merges when APIView comments remain unresolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, github
Domain
ci-cd, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.