Azure / Azure/azure-sdk-tools

[DotNet] BuildAnalysis does not show deleted files in the PR

Open
#3,258 1 comment 0 reactions 1 assignee Claimed by @ArcturusZhang View on GitHub
Client CodeGen
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

The `Code Check` script is using `git diff` command to check if the code is up-to-date, therefore it might not be able to catch the "untracked" files in git: https://github.com/Azure/azure-sdk-for-net/blob/dfcc1226d2de34048723977f499f40fb4abe34eb/eng/scripts/CodeChecks.ps1#L165
Therefore if we just remove some files in a PR, the regeneration will recreate those removed files. Since these files are untracked and not got catched in `git diff`, the CI will pass, which is a false negative.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.