Azure / Azure/azure-sdk-tools

[Test-Proxy] Handle `Host` header properly

Open
#3,211 0 comments 0 reactions 1 assignee Claimed by @scbedd View on GitHub
Central-EngSys Test-Proxy
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

1. We should be taking the `host` header as-is if the target is not the localhost address (EG the co-opted test-proxy endpoint)
2. If the user provides `x-recording-upstream-host-header` we should honor that
3. In all cases, It should still be recorded (it is not currently)

It is a discussion as to whether or not we want to just ignore a bad host header set targeting the test-proxy localhost address.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.