Azure / Azure/azure-sdk-tools

[ApiView] .NET reviews not showing `new` modifier

Open
#3,065 0 comments 1 reaction 0 assignees View on GitHub
.NET APIView
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

The [actual API for `TokenCredentialOptions.Diagnostics`](https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs#L311) looks like:

```C#
public new Azure.Identity.TokenCredentialDiagnosticsOptions Diagnostics { get; }
```

But [ApiView is only showing us](https://apiview.dev/Assemblies/Review/6a40db7f9eeb41dabfe5768f1e796c81#Azure.Identity.TokenCredentialOptions):

```C#
public TokenCredentialDiagnosticsOptions Diagnostics { get; }
```

Using newslot can be tricky so it's important that ApiView calls it out.

Contributor guide

Open the contributing guide

Research direction

The expected declaration is in sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs at the referenced Diagnostics entry; compare it with the ApiView review for TokenCredentialOptions. Find the .NET ApiView parsing or rendering entry point and its tests, then verify that the generated review preserves the `new` modifier.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.