Azure / Azure/azure-sdk-tools

[CSharp] Update AZ0002 to understand `RequestOptions`

Open
#1,715 0 comments 0 reactions 0 assignees View on GitHub
API Analyzer Client
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

LLC generates methods where the last parameter is a `RequestOptions`. In this cases, the `RequestOptions` type holds a `CancellationToken` so we should not flag cases where methods which take a `RequestOptions`.

We are suppressing this error today in some LLC's and we should remove that when this work is done.

Contributor guide

Open the contributing guide

Research direction

Start by locating the AZ0002 analyzer and the LLC-generated methods that take RequestOptions. Check how RequestOptions and its CancellationToken are currently handled, then review the existing LLC suppressions. Done means AZ0002 no longer flags these methods and the corresponding suppressions can be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.