Azure / Azure/azure-sdk-tools

Moving Pipeline Analysis Next Steps and Auto Fix logic into .js files

Open
#16,930 0 comments 0 reactions 1 assignee Claimed by @danieljurek View on GitHub
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
130

Description

Both the [analysis](https://github.com/Azure/azure-sdk-for-python/blob/main/.github/workflows/pipeline-analysis-next-steps.md) and [fix](https://github.com/Azure/azure-sdk-for-python/blob/main/.github/workflows/pipeline-analysis-auto-fix.md) GitHub Agentic Workflows contain inline JavaScript business logic.

We should instead be following the conventions established by the [azure-rest-api-specs/.github/workflows](https://github.com/Azure/azure-rest-api-specs/tree/main/.github/workflows) implementation:
- Business logic should exist in .github/workflows/src.
- Unit tests should exist in .github/workflows/test

This will keep business logic decoupled from the workflow and allow us to test the workflow behavior before running the complete GitHub Action. This will also allow for us to add GitHub API request and rate-limit logging as shown (here)[https://github.com/Azure/azure-rest-api-specs/blob/main/.github/workflows/src/github.js]

**Success Criteria**
- Business logic defined in the analysis and fix GitHub Agentic Workflows are moved into imported JavaScript files, with unit tests to cover them.
- GitHub API logging is implemented into every common GitHub Agentic Workflow.
- Test files remain only in the azure-sdk-tools repository for common files.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.