Azure / Azure/azure-sdk-tools

CODEOWNERS Cleanup: Restrict codeowners enforcement skipping to specified emails

Open
#16,510 0 comments 0 reactions 0 assignees View on GitHub
needs-triage
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
144

Description

The `verify-codeowners.yml` pipeline template should allow skipping codeowners verification for the same reasons as `create-apireview.yml`, but restricted to an approved set of email addresses rather than allowing anyone to bypass it via `Skip.VerifyCodeowners`.

## Scope

- Add an evaluation step that sets a single pipeline variable (`ShouldSkipVerifyCodeowners`) which the later verification steps gate on.
- Only skip when `Skip.VerifyCodeowners` is `true` **and** the requesting email (`Build.RequestedForEmail`) is in an allowed set.
- Allowed set = a default list of emails plus additional emails supplied via a new `AllowSkipEmails` template parameter.

Part of the CODEOWNERS cleanup work (#14754).

Contributor guide

Open the contributing guide

Research direction

Start with the verify-codeowners.yml pipeline template and compare its skip behavior with create-apireview.yml. Trace the later verification steps and confirm they use the single ShouldSkipVerifyCodeowners variable. Done means skipping occurs only for true Skip.VerifyCodeowners requests from the default or AllowSkipEmails set, while other requests still verify CODEOWNERS.

Written by the indexing model from the issue text.

Assessment

Domain
ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.