Azure / Azure/azure-sdk-tools

[APIView][js-parser] protected properties showing as public

Open
#15,759 0 comments 0 reactions 1 assignee Claimed by @KarishmaGhiya View on GitHub
APIView Javascript
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
130

Description

An example can be seen in storage-blob:

APIView shows as:

```ts
export class BlobClient extends StorageClient {
blobClientConfig?: BlobClientConfig;
}
```

[link](https://spa.apiview.dev/review/481422771b7d4e2cb37cc95fc00faba2?activeApiRevisionId=74dcdfe47c754ad4b36712b09c9e66ed&diffApiRevisionId=5cd629caf3264daeb36b4ff1415b79ba&diffStyle=trees&nId=@azure%2Fstorage-blob!BlobClient%23blobClientConfig:member)

But it is actually protected as shown in the codebase: [link](https://github.com/Azure/azure-sdk-for-js/blob/5b5994701c8b713b92cc3690fb3fcaa4c22e8474/sdk/storage/storage-blob/src/Clients.ts#L962)

It's possible that the parser is dropping `protected` but I'd expect to continue to see protected keyword in APIView

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.