Azure / Azure/azure-sdk-tools

.NET: Add support for SyncAsyncEventHandlerExtensions.RaiseAsync to async analyzer

Open
#1,357 0 comments 0 reactions 0 assignees View on GitHub
API Analyzer Client
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

See https://github.com/Azure/azure-sdk-for-net/pull/18170 until SyncAsyncEventHandler is merged into Azure.Core.

`SyncAsyncEventHandlerExtensions.RaiseAsync` doesn't take `bool async` and `CancellationToken cancellationToken` parameters because they're already being passed in the `SyncAsyncEventArgs`. We should update the analyzer to verify this as part of the pattern. This is a lower priority because we will not have very many `SyncAsyncEventHandler`s.

Contributor guide

Open the contributing guide

Research direction

Start with the async analyzer entry point that handles SyncAsyncEventHandler patterns and read the referenced Azure SDK pull request for the SyncAsyncEventHandler design. Verify how SyncAsyncEventHandlerExtensions.RaiseAsync is recognized when async and cancellationToken are carried by SyncAsyncEventArgs, and update the analyzer's validation accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.