Azure / Azure/azure-sdk-tools

Apply Registered `GeneralRegex` sanitizers to `Variables` before storage

Open
#13,279 0 comments 0 reactions 0 assignees View on GitHub
Test-Proxy
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
130

Description

A bunch of the commandtests in microsoft/mcp actually end up needing to store a full id.

It'll look something like this if we don't sanitize:

```
"Variables": {
"amlfsSubnetSmallId": "/subscriptions//resourceGroups//providers/Microsoft.Network/virtualNetworks/lustrerecord-vnet/subnets/amlfs-small",
"Location": "westus"
}
```

and the like. This is likely a breaking change to new recordings in certain circumstances for the azure-sdk-for-net repo, so this will be an option on `Record/StopRecording`

Contributor guide

Open the contributing guide

Research direction

Start at the Record/StopRecording entry points and trace how Variables are stored and how registered GeneralRegex sanitizers are applied. Confirm how the option should affect new recordings and verify that full resource IDs are sanitized before storage without changing behavior when the option is disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.