Azure / Azure/azure-sdk-tools

`check-enforcer` still getting stuck in hung state

Open
#12,942 3 comments 0 reactions 0 assignees View on GitHub
needs-triage
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

This is very interesting. @dargilco has seen increasing incidents of this behavior.

Check enforcer can be re-evaluated, but the pr is still in a stuck state. This JS PR is an excellent example of this behavior:

- [The PR]()
- [The check-enforcer associated with the latest check_suite completion](https://github.com/Azure/azure-sdk-for-js/pull/36649/checks)

As you can see:

```
Handling check suite event.
GET to https://api.github.com/repos/Azure/azure-sdk-for-js/commits/95be886abaccb0e43979f98d0e7c0a41faa53c04/check-suites
Received 200 OK
Check suite conclusion for 'Azure Pipelines' is 'success'.
Check suite conclusion for 'GitHub Actions' is 'success'.
Check suite conclusion for 'GitHub Actions' is 'success'.
Check suite conclusion for 'GitHub Actions' is 'success'.
Check suite conclusion for 'GitHub Actions' is 'success'.
Check suite conclusion for 'GitHub Actions' is 'success'.
Check suite conclusion for 'GitHub Actions' is 'success'.
Check suite conclusion for 'GitHub Actions' is 'cancelled'.
POST to https://api.github.com/repos/Azure/azure-sdk-for-js/statuses/95be886abaccb0e43979f98d0e7c0a41faa53c04 with state pending
```

There is absolutely a cancelled github actions, so obviously the pending state is going to stick around. Need to identify the origin of that pending check, and resolve.

Contributor guide

Open the contributing guide

Research direction

Start with the check-enforcer handling of the check suite event and the GitHub check-suites and statuses API calls shown in the issue. Trace the example pull request and determine why a cancelled check leaves the status pending; done means the associated pending state resolves correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, github-actions
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.