Azure / Azure/azure-sdk-tools

.NET Client SDK Analyzers .ctor rules firing false positives

Open
#127 2 comments 0 reactions 1 assignee Claimed by @pakrym View on GitHub
API Analyzer
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

Storage triggers the following analyzer rules but I think they're false positives:

- AZC0006: The guidelines show you can have optional `*ClientOptions` for your less important ctors per https://azuresdkspecs.z5.web.core.windows.net/DotNetSpec.html#dotnet-client-ctor-overloads but the rule appears to be more strict by demanding separate overloads

- AZC0007: This is looking for `AppendBlobClientOptions` instead of `BlobClientOptions` and firing

You can repro by removing the `NoWarn`s at https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/storage/Directory.Build.props#L19

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.