Azure / Azure/azure-sdk-tools

[Python APIView] fix token file generation CI to fail on correct job

Open
#11,482 1 comment 1 reaction 2 assignees Claimed by @swathipil View on GitHub
APIView Python
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

Currently, if the generation job fails in the APIView pipeline, it's still green but then fails on the sending the request to APIView. Instead, we want to catch and fail in the correct place to make it easier for users to debug.

ex.

Image

To fix this issue:
1. Make a change to "Generate APIView Token files" so that the job fails/is red when there's an error: https://github.com/Azure/azure-sdk-tools/blob/1df17eef13f8ea2d3f72f4ac2cdbe15e93fef70e/eng/pipelines/templates/steps/apiview-review-gen.yml#L20

Note that the error may look like a Python error, JS error, or something else.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.