Azure / Azure/azure-sdk-tools

Analyzer to err when referencing virtual members in constructor of defining class

Open
#1,073 1 comment 0 reactions 0 assignees View on GitHub
API Analyzer Client
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

In reference to PR https://github.com/Azure/azure-sdk/pull/1888 for the [reiterated requirement to note reference virtual members of the class defining the constructor](https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-client-constructor-use-params), we should have an analyzer that errs when you do this. Maybe it could see if there's a corresponding parameter (or if one was used to set the property), but at least erring calls attention to fixing this issue.

Contributor guide

Open the contributing guide

Research direction

Start by reading PR 1888 and the linked .NET constructor guidance to establish the required behavior, then locate the analyzer implementation and its existing tests. Done means the analyzer reliably reports references to virtual members from the defining class's constructor, with coverage for the supported constructor patterns.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.