Azure / Azure/azure-sdk-tools

[APIView] Do not remove automatic revision if revision is for a different package version

Open
#10,105 2 comments 0 reactions 0 assignees View on GitHub
APIView bug
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

CI build automatic revision every day and APIView deletes latest pending revision when a new request is processed to create automatic revision that has API changes. We should remove automatic revision only if it is for same package version to avoid removing an automatic version (in pending status) that was created for a different package version.

Context: Go azcore had version 1.17.0 in pending status and they released a hotfix which removed the revision for 1.17.0 even though it's for a different package version. This causes issue in API change detection in PR when all further PR is compared against latest automatic revision created for hotfix instead of comparing against latest main branch revision.

Contributor guide

Open the contributing guide

Research direction

Start by locating the APIView code that deletes the latest pending automatic revision when processing a new request. Trace how the revision's package version is available for comparison, then verify that a revision for a different package version is retained while one for the same version is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.