Azure / Azure/azure-sdk-for-rust
cargo-semver-checks is failing on Key Vault SDK
- Dominant language
- Rust
- Stars
- 884
- Forks
- 365
- Avg merge
- 2d 19h
- Merged PRs (30d)
- 112
Description
Seems [`cargo-semver-checks` is not checking out symlinks](https://github.com/obi1kenobi/cargo-semver-checks/issues/1718), which fails for Key Vault Secrets and Certificates because they symlink `authorizer.rs` from Keys:
```
error[E0583]: file not found for module `authorizer`
--> /home/heaths/src/azure-sdk-for-rust/target/semver-checks/git-azure_security_keyvault_secrets_1_0_0/fd2cf10e8968554dafe01a113374bbd97b4eadbb/sdk/keyvault/azure_security_keyvault_secrets/src/lib.rs:7:1
|
7 | mod authorizer;
| ^^^^^^^^^^^^^^^
|
```
## Proposal
Instead of symlinking, we could copy these; however, it's not going to help the case for any version of Secrets or Certificates where it was still a symlink. I'd prefer getting (or even making) a fix upstream in `cargo-semver-checks`.
Contributor guide
Assessment
This issue has not been assessed yet.