Azure / Azure/azure-sdk-for-rust

cargo-semver-checks is ignoring Cargo.lock and time@0.3.48 causes a regression

Open
#4,585 0 comments 2 reactions 1 assignee Claimed by @heaths View on GitHub
EngSys
Dominant language
Rust
Stars
884
Forks
365
Avg merge
2d 19h
Merged PRs (30d)
109

Description

PRs started failing during our `cargo semver-checks` run. Even going back to `azure_core@1.0.0` trying to bisect this, it was failing. Seems it's a combination of two things:

1. https://github.com/time-rs/time/issues/783
2. https://github.com/obi1kenobi/cargo-semver-checks/issues/675

Even though we have `time` currently pinned to 0.3.47, `cargo-semver-checks` is ignoring it. Until at least 1 of the two issues above are fixed, we need to disable semver-checks.

This is a tracking issue to re-enable it once one of those two is fixed at least.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.