Azure / Azure/azure-sdk-for-rust

Make sure workspace Cargo.toml dependencies not version-bumped after release

Open
#4,398 0 comments 0 reactions 1 assignee Claimed by @heaths View on GitHub
Azure.Core Client EngSys
Dominant language
Rust
Stars
884
Forks
365
Avg merge
2d 19h
Merged PRs (30d)
109

Description

In #4395 the workspace `/Cargo.toml` was updated to bump versions for core. Post-GA we don't want this, though. The crate versions should bump to what's next, yes, but the dependencies should be version-only dependencies for what just released.

I was told this shouldn't happen once `path` is removed - which I'm doing in #4395 manually after our initial GA - but looking at `eng/scripts/update-pathversions.rs` I'm not sure. `update_package_versions` has this comment which seems inverse of what we want:

```rust
// for each dependency table, for each package in package_versions
// if the package is in the dependency table
// if the dependency has both path and version properties, update the version property
// if the dependency has has path, but not version, add the version property only if
// 1. the table name is not "dev-dependencies"
// 2. the package is not publish disabled
// 3. the add flag is true
```

This is really just a tracking issue to make sure what we expect post-GA happens for the next release, since this first time was a one-off since we're now removing the `path` dependency we had intentionally during early development.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.