Azure / Azure/azure-sdk-for-python

Clean up AnalyzeTextAsyncLROPoller logic before GA/next beta

Open
#42,935 0 comments 0 reactions 1 assignee Claimed by @amber-Chen-86 View on GitHub
Client Cognitive - Language Cognitive - Text Analytics
Dominant language
Python
Stars
5.6k
Forks
3.4k
Avg merge
1d 21h
Merged PRs (30d)
193

Description

During PR review (https://github.com/Azure/azure-sdk-for-python/pull/42685), reviewers flagged the complexity of the patched poller used to expose details in AnalyzeTextAsyncLROPoller (and the sync peer).
It should be relatively straightforward to patch a poller to expose the `details` property, and we should reduce paging complexity while preserving `ItemPaged/AsyncItemPaged` behavior.

Another refactor(PR: https://github.com/Azure/azure-sdk-for-python/pull/42928): Once the LRO finishes, should any actions still be “in progress”? If terminal LRO ⇒ in_progress should be 0, we likely shouldn’t surface this on the result page.

We’ll aim to simplify in the next beta or GA.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.