Azure / Azure/azure-sdk-for-java

Consider give `RequestContext.addRequestCallback` a better name

Open
#45,673 0 comments 1 reaction 1 assignee Assigned to @Copilot View on GitHub
Client clientcore
Dominant language
Java
Stars
2.6k
Forks
2.2k
Avg merge
2d 8h
Merged PRs (30d)
178

Description

The API name `addRequestCallback()` in `RequestContext` is a bit confusing, the name to me is that the callback will be executed after the request being sent, because usually a callback is executed when something complete. But in fact, this callback will be executed before the request being sent.

code here: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/clientcore/core/src/main/java/io/clientcore/core/http/models/RequestContext.java#L249

Potential name: `addBeforeRequestHook()`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.