Azure / Azure/azure-sdk-for-java

[BUG] code-quality-report CI is detecting checkstyle violations not picked by core-v2 library CI

Open
#45,389 1 comment 0 reactions 1 assignee Assigned to @samvaity View on GitHub
Azure.Core.V2 clientcore
Dominant language
Java
Stars
2.6k
Forks
2.2k
Avg merge
2d 8h
Merged PRs (30d)
178

Description

Seems there is currently no fromSource run for v2 libraries.
https://github.com/Azure/azure-sdk-for-java/pull/45295

However, we have that for code-quality-report CI. It will check all `io.clientcore` dependents, which will include all v2 libraries:
https://github.com/Azure/azure-sdk-for-java/pull/45387/checks?check_run_id=42458413428

code-quality-report CI then would fail for checkstyle violations for v2 libraries that haven't been detected previously PR's CI.

How should we deal with this?

Potential candidate:
1. Add suppression for v2 libraries in [checkstyle-suppressions.xml](https://github.com/Azure/azure-sdk-for-java/blob/main/eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.