Azure / Azure/azure-sdk-for-java

Look at possibly changing a few things in ci.yml

Open
#43,984 0 comments 0 reactions 1 assignee Claimed by @JimSuplizio View on GitHub
EngSys
Dominant language
Java
Stars
2.6k
Forks
2.2k
Avg merge
2d 8h
Merged PRs (30d)
178

Description

This issue is due to comments made by @weshaggard in this PR review.

1. Look at using [verify-readmes.yml](https://github.com/Azure/azure-sdk-for-java/pull/43904/files#diff-23849bb529451be6bf226bc895f60373a9181f673e6273d84474158a912d795bR335) in all cases.
2. Look at using [verify-links.yml](https://github.com/Azure/azure-sdk-for-java/pull/43904/files#diff-23849bb529451be6bf226bc895f60373a9181f673e6273d84474158a912d795bR352) in call cases
3. Look at using [verify-changelogs.yml](https://github.com/Azure/azure-sdk-for-java/pull/43904/files#diff-23849bb529451be6bf226bc895f60373a9181f673e6273d84474158a912d795bR379) in call cases.

There are a couple of issues with these
1. In order to do these, we'd have to make the Analyze job depend on the Build job which is not something I'm wanting to do, I don't like the idea of losing the parallelization. For something like core, this isn't a big deal but for smaller pipelines, like template it'll overall increase the run time.
2. Even if we did the first item, above, there would still need to be a check for the PR pipeline in the case of verify-samples.yml since I'd need to get the ServiceDirectory list from the diff.json

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.