Azure / Azure/azure-sdk-for-cpp

Check git staging failures in Update-VcpkgPort.ps1

Open
#7,362 0 comments 0 reactions 0 assignees View on GitHub
bug EngSys
Dominant language
C++
Stars
205
Forks
172
Avg merge
1d 15m
Merged PRs (30d)
33

Description

## Summary

Both `git add -A` calls in `eng/scripts/Update-VcpkgPort.ps1` lack immediate `$LASTEXITCODE` checks.

## Motivation

This behavior exists on `main` and predates PR #7361. A staging failure is reported as a later commit failure.

## Proposal

Check each staging command immediately. Emit a staging-specific error. Cover both temporary and final commit paths.

Found while reviewing #7361.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.