Azure / Azure/azure-sdk-for-cpp

Ensure that version in vcpkg.json and AzureVcpkg.cmake are the same

Open
#6,878 0 comments 1 reaction 0 assignees View on GitHub
Central-EngSys EngSys
Dominant language
C++
Stars
205
Forks
172
Avg merge
1d 3h
Merged PRs (30d)
37

Description

Dependabot opens updates to vcpkg.json but has no way of updating AzureVcpkg.cmake. When the two values diverge it can result in bad build behavior.

Two possible fixes:

* Have AzureVcpkg.cmake read the value from vcpkg.json (requires upgrading minimum cmake version to 3.19) OR
* Have some kind of additional check that fails if the values in those files differ OR
* A GitHub Action (or some kind of automation) that updates PRs opened by dependabot when it makes sense to do so

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.