Azure / Azure/azure-sdk-for-cpp
Set LiveTestCtestRegex to match CtestRegex in ci.yml across the repo, in a consistent format, following the template project.
- Dominant language
- C++
- Stars
- 205
- Forks
- 172
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 37
Description
Tables' ci.yml was the only one that was inconsistent. All other instances within the repo have the `LiveTestCtestRegex` value match `CtestRegex`, so we fixed it in https://github.com/Azure/azure-sdk-for-cpp/pull/6223, for consistency.
That said, some use wild-card (`*`), while others have it wrapped in quotes (`""`), while the rest leave it as plain-text:
https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-cpp%20LiveTestCtestRegex&type=code
**We should consider picking a viable format, and apply it consistently, to avoid confusion.**
A strawman proposal is to have it be unquoted, without the wild card, matching what we have in our template and core project:
`azure-template`
`azure-core`
`azure-security-keyvault`
`azure-storage`
**Open question:**
Would it make a difference to the set of tests that get matched/run if the regex value ended with a period `.` or not?
https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/template/ci.yml#L29
https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/keyvault/ci.yml#L30-L31
https://github.com/Azure/azure-sdk-for-cpp/blob/384552adff3d6cdea46cdf8a345120b183bdcc1e/sdk/storage/ci.yml#L30-L33
Contributor guide
Assessment
This issue has not been assessed yet.