Azure / Azure/azure-sdk-for-cpp
Azure Data Tables tests should not have cross-service packages source dependency on storage common tests
- Dominant language
- C++
- Stars
- 205
- Forks
- 172
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 37
Description
We typically avoid dependencies between service SDKs to create isolation, clean dependency hierarchy/tree, and avoid unintended consequences on other packages when another SDK package is changed.
All service SDKs need to depend on azure-core. Some service SDKs (such as storage) have a storage-common package.
But we don't expect different service packages to depend on each other.
The same applies to tests as well, so we should consider isolating them too.
https://github.com/Azure/azure-sdk-for-cpp/blob/d835e1a3b1970e53ceda94ef1c6d0596cd103d02/sdk/tables/azure-data-tables/test/ut/CMakeLists.txt#L30-L32
https://github.com/Azure/azure-sdk-for-cpp/blob/d835e1a3b1970e53ceda94ef1c6d0596cd103d02/sdk/tables/azure-data-tables/test/ut/CMakeLists.txt#L40-L41
Some of the usage includes:
https://github.com/Azure/azure-sdk-for-cpp/blob/d835e1a3b1970e53ceda94ef1c6d0596cd103d02/sdk/tables/azure-data-tables/test/ut/table_client_test.cpp#L41-L42
https://github.com/Azure/azure-sdk-for-cpp/blob/d835e1a3b1970e53ceda94ef1c6d0596cd103d02/sdk/tables/azure-data-tables/test/ut/table_client_test.cpp#L118
cc @gearama, @RickWinter
Contributor guide
Assessment
This issue has not been assessed yet.