Azure / Azure/azure-sdk-for-cpp

The `_detail` and `_internal` namespace should be the last one in the chain of namespace following SDK design precedence

Open
#6,120 7 comments 0 reactions 0 assignees View on GitHub
design-discussion Tables
Dominant language
C++
Stars
205
Forks
172
Avg merge
1d 3h
Merged PRs (30d)
37

Description

We currently have types in headers that are in the `_detail` namespace which contain sub-namespaces like `Cryptography`.
https://github.com/Azure/azure-sdk-for-cpp/blob/0e699e4c7a39078daba7d902f9ee9b5b98b1b5cf/sdk/tables/azure-data-tables/inc/azure/data/tables/internal/cryptography/url_encode.hpp#L12

The existing precedence in the SDK is that `_detail`/`_internal` is the last component of the namespace.
See examples:
https://github.com/Azure/azure-sdk-for-cpp/blob/0e699e4c7a39078daba7d902f9ee9b5b98b1b5cf/sdk/core/azure-core/inc/azure/core/internal/cryptography/sha_hash.hpp#L18
https://github.com/Azure/azure-sdk-for-cpp/blob/0e699e4c7a39078daba7d902f9ee9b5b98b1b5cf/sdk/core/azure-core/inc/azure/core/internal/credentials/authorization_challenge_parser.hpp#L15-L16

cc @RickWinter

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.