Azure / Azure/azure-rest-api-specs

[ARM Auto SignOff] Incorrectly removing label `ARMSignedOff`, if trivial=true

Open
#40,135 0 comments 0 reactions 1 assignee Claimed by @AkhilaIlla View on GitHub
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
2d 22h
Merged PRs (30d)
444

Description

PR:
- https://github.com/Azure/azure-rest-api-specs/pull/39353

Workflow run with bug:
- https://github.com/Azure/azure-rest-api-specs/actions/runs/21654131664/job/62425266643

wf starts, PR has label ARMSignedOff:

Image

you determine, auto-signoff yes, due to trivial-changes:

Image

L93: auto-signoff=yes
L33: you flip ARMSignedOff from true to false

Image

From: Akhila
> Ah, I know why. Thats because the trivial change auto sign off is enabled in test mode, so we dont want to add the ARMAutoSignOff label, hence set to false.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.