Azure / Azure/azure-rest-api-specs
[TypeSpec] Should not add ARMReview label for any SDK configuration PR
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 444
Description
If a TypeSpec PR only updates `client.tsp` and `tspconfig.yaml` for SDK generation configuration, the `ARMReview` label should not be applied.
Here is the comments from @mikeharder of this problem:
`ARMReview` is applied to any PR that changes any file under a resource-manager folder. To my knowledge, it has always worked this way.
https://github.com/Azure/azure-rest-api-specs/blob/70bd6219f7e8edbc62528fc39b757570082011c9/eng/tools/summarize-impact/src/impact.ts#L159-L161
https://github.com/Azure/azure-rest-api-specs/blob/7eb817d513e6b2364a823d1f56db45d25fdca7b7/.github/workflows/src/summarize-checks/labelling.js#L537
What might be a recent change, is in folder structure v2, the TSP sources are moved under the resource-manager folder. While in folder structure v1, the TSP sources were outside resource-manager.
So in v1, changes to only `client.tsp` and `tspconfig.yaml` would not trigger `ARMReview`, since they are outside resource-manager, and they don't cause any changes to generated swagger under resource-manager. But in v2, changes to `client.tsp` and `tspconfig.yaml` will trigger `ARMReview`.
So now we need to fix this and make sure any SDK generation configuration change should not trigger `ARMReview`.
Contributor guide
Assessment
This issue has not been assessed yet.