Azure / Azure/azure-rest-api-specs
[context.js] Improve error handling if there are multiple PRs with the same SHA
Open
- Dominant language
- TypeSpec
- Stars
- 3.1k
- Forks
- 5.9k
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 444
Description
Already improved error message to log PR objects:
https://github.com/Azure/azure-rest-api-specs/blob/5d6039f84b7f9e6a0332d28ed34b86d8ebbd52b3/.github/workflows/src/context.js#L173-L175
However, still remaining issues:
1. If search API returns multiple issues, we use first. Maybe should also throw?
https://github.com/Azure/azure-rest-api-specs/blob/5d6039f84b7f9e6a0332d28ed34b86d8ebbd52b3/.github/workflows/src/issues.js#L35-L39
2. The WF that fail will likely be triggered on `workflow_run`, meaning it won't appear in the PR checks UI. They will just see checks never completing. Is there some way we can get an error in the impacted PRs?
Contributor guide
Assessment
This issue has not been assessed yet.