Azure / Azure/azure-rest-api-specs

[BUG] AWS Access Key Id in example causes GitHub to block pushes

Open
#28,404 2 comments 0 reactions 1 assignee Claimed by @aymanjarrousms View on GitHub
bug customer-reported Mgmt question
Dominant language
TypeSpec
Stars
3.1k
Forks
5.9k
Avg merge
3d 2h
Merged PRs (30d)
424

Description

### API Spec link

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/security/resource-manager/Microsoft.Security/preview/2020-01-01-preview/examples/Connectors/CreateUpdateAwsCredConnectorSubscription_example.json#L23

### API Spec version

2020-01-01

### Describe the bug

This example contains the line
```
"awsAccessKeyId": "AKIARPZCNODDNAEQFSOE",
```

It seems that GitHub has expanded their secret scanning. At Pulumi, we generate a JSON schema and code from the Azure examples. Our generated code is now blocked from being pushed to GitHub, without extra workarounds, due to this key.

### Expected behavior

The Azure spec examples don't contain real-looking secrets including AWS access key ids, so that pushing derived schemas or code to GitHub succeeds.

### Actual behavior

```
remote: - GITHUB PUSH PROTECTION
remote: ——————————————————————————————————————————————————————
remote: Resolve the following secrets before pushing again.
remote:
remote: (?) Learn how to resolve a blocked push
remote: https://docs.github.com/code-security/secret-scanning/pushing-a-branch-blocked-by-push-protection
remote:
remote:
remote: —— Amazon AWS Access Key ID ——————————————————————————
remote: locations:
remote: - commit: f1b05bccccfa232413de3e74d1c34c189e536117
remote: path: provider/cmd/pulumi-resource-azure-native/schema.json:652276
remote: - commit: f1b05bccccfa232413de3e74d1c34c189e536117
remote: path: provider/cmd/pulumi-resource-azure-native/schema.json:652276
remote: - commit: f1b05bccccfa232413de3e74d1c34c189e536117
remote: path: provider/cmd/pulumi-resource-azure-native/schema.json:652276
remote: - commit: f1b05bccccfa232413de3e74d1c34c189e536117
remote: path: provider/cmd/pulumi-resource-azure-native/schema.json:652276
remote: - commit: f1b05bccccfa232413de3e74d1c34c189e536117
remote: path: provider/cmd/pulumi-resource-azure-native/schema.json:652276
```

### Reproduction Steps

I don't have a concrete repro step but [here's one of our workflows failing due to this](https://github.com/pulumi/pulumi-azure-native/actions/runs/8375101189/job/22931736819#step:7:4471).

### Environment

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.